-
Notifications
You must be signed in to change notification settings - Fork 14.6k
KAFKA-19707 [WIP] can't upgrade Develocity Gradle plugin (for both Gradle 8 and Gradle 9) #20450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
796f64f
to
f353b35
Compare
9af9e3e
to
b49e361
Compare
Much obliged Ken @m1a2st 👌 ! |
a4b5a04
to
aab4325
Compare
387cc1a
to
6a0e737
Compare
6a0e737
to
e89f1c0
Compare
6d822a5
to
44537ad
Compare
A label of 'needs-attention' was automatically added to this PR in order to raise the |
a587f7e
to
89fadf8
Compare
89fadf8
to
52e16e5
Compare
A label of 'needs-attention' was automatically added to this PR in order to raise the |
It seems that this issues described here are solved (see comment here: #19513 (comment)) but I opt to keep this PR around until #19513 is merged. |
497a87e
to
12dd5f9
Compare
12dd5f9
to
0fdbdd0
Compare
A label of 'needs-attention' was automatically added to this PR in order to raise the |
…3.19 -->> 3.19.2) note: it's expected for build to fail
2f63142
to
d930867
Compare
…bumped (3.19 -->> 3.19.2)" This reverts commit d930867.
…rsion (i.e. file `unixStartScript.txt`) was being referenced (cherry picked from commit 9305e0b)
details: - gradle: 8.14.3 -->> 9.0.0 - https://github.com/gradle/gradle/releases/tag/v9.0.0 - https://gradle.org/whats-new/gradle-9 - https://docs.gradle.org/9.0.0/userguide/upgrading_major_version_9.html#changes_major_9 - shadow plugin: 8.3.6 -->> 9.0.2 - https://github.com/GradleUp/shadow/releases/tag/9.0.0 - https://github.com/GradleUp/shadow/releases/tag/9.0.1 - https://github.com/GradleUp/shadow/releases/tag/9.0.2 refactoring (performed in order to accomodate Gradle 9 breaking changes): - tasks `siteDocsTar` and `releaseTarGz` are moved out of `core` (and into a new dummy module: `distribution`); note that distribution destination folder stays as-is (:core) - `preserveFileTimestamps` Tar taks property value explicitly set to `true` (default values: Gradle 8: `true`, Gradle 9: 'false') - files and folders permissions are introduced - git placeholder file (.gitkeep) is added in order to preserve `distribution` folder (Apache Rat check for that file is skipped) - `wrapper.gradle` changes: no need to check number of dots for Gradle versions >=9 anymore - redundant 'gradleVersion' ext property is removed (in favor of 'versions.gradle' usage) (cherry picked from commit 14203aa)
… dependencies/plugins and GitHub Actions details: - `setup-gradle` GitHub Action: 4.3.0 -->> 4.4.3 (note: this version was tested against Gradle 9) - grgit: 4.1.1 -->> 5.3.0 - gradle versions plugin: 0.48.0 -->> 0.52.0 - owasp dependency check : 8.2.1 -->> 12.1.3 - spotbugs: 6.2.3 -->> 6.2.5 - spotless: 6.25.0 -->> 7.2.1 - Zinc Scala compiler: 1.9.2 -->> 1.10.8 (cherry picked from commit d01ace0)
… a `upgrade-system-tests*` submodules related link: https://docs.gradle.org/9.0.0/userguide/upgrading_major_version_9.html#test_task_fails_when_no_tests_are_discovered (cherry picked from commit a0646ff)
…hen no test are discovered (i.e. solution for KAFKA-16801 is expanded) (cherry picked from commit f0946db)
…adle.develocity` plugin version same as in trunk: 3.19) note: it's expected for build to pass (i.e. build scans will be published and available on Develocity instance)
…3.19 -->> 3.19.2) note: it's expected for build to fail
Title is too long (over 120 characters); changing that. |
Note: started as an offshoot of this PR:
Related JIRA ticket: https://issues.apache.org/jira/browse/KAFKA-19707
Environment:
https://develocity.apache.org/scans?search.rootProjectNames=kafka
(definition is here: .github/actions/setup-gradle/action.yml)
Scenario:
com.gradle.develocity
Gradle plugin version from a currentversion (3.19) to any recent version (3.19.1 and/or more recent)
published") for both Gradle 8.14.3 and Gradle 9.0.0
wrong Gradle version (8.14.3)
Test cases:
(no surprises here, it's a trunk after all)
d930867
https://github.com/apache/kafka/actions/runs/17714050963
3b62473
link
e1a4ff5
https://github.com/apache/kafka/actions/runs/17719128481
wrong: 8.14.3 (not 9.0.0)