Skip to content

Conversation

dejan2609
Copy link
Contributor

@dejan2609 dejan2609 commented Sep 1, 2025

Note: started as an offshoot of this PR:


Related JIRA ticket: https://issues.apache.org/jira/browse/KAFKA-19707

Environment:

  • Develocity instance (version 2025.2.4):
    https://develocity.apache.org/scans?search.rootProjectNames=kafka
  • Gradle version 8.14.3, GitHub Actions for Gradle builds: 4.3.0
  • Gradle version 9.0.0, GitHub Actions for Gradle builds: 4.4.3
  • note: Github Actions for Gradle is using wrapper Gradle version
    (definition is here: .github/actions/setup-gradle/action.yml)

Scenario:

  • upgrade com.gradle.develocity Gradle plugin version from a current
    version (3.19) to any recent version (3.19.1 and/or more recent)
  • GitHub Action build breaks (with this error: "build scan failed to be
    published") for both Gradle 8.14.3 and Gradle 9.0.0
  • note for commit that contains Gradle 9.0.0: Github Actions build shows
    wrong Gradle version (8.14.3)

Test cases:

@github-actions github-actions bot added triage PRs from the community build Gradle build or GitHub Actions small Small PRs labels Sep 1, 2025
@dejan2609
Copy link
Contributor Author

Hi @mumrah and @chia7712
Could you please approve workflow runs for this PR ?

@dejan2609
Copy link
Contributor Author

Much obliged Ken @m1a2st 👌 !

@dejan2609 dejan2609 force-pushed the KAFKA-19654 branch 2 times, most recently from a4b5a04 to aab4325 Compare September 4, 2025 16:20
@github-actions github-actions bot added tools and removed small Small PRs labels Sep 4, 2025
@github-actions github-actions bot added the small Small PRs label Sep 5, 2025
@github-actions github-actions bot removed the small Small PRs label Sep 5, 2025
@github-actions github-actions bot added small Small PRs and removed small Small PRs labels Sep 6, 2025
Copy link

github-actions bot commented Sep 9, 2025

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@dejan2609 dejan2609 marked this pull request as draft September 10, 2025 11:52
@dejan2609 dejan2609 marked this pull request as ready for review September 10, 2025 16:35
@dejan2609 dejan2609 marked this pull request as draft September 10, 2025 20:42
@dejan2609 dejan2609 marked this pull request as ready for review September 11, 2025 07:02
@dejan2609 dejan2609 marked this pull request as draft September 11, 2025 21:09
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@dejan2609
Copy link
Contributor Author

It seems that this issues described here are solved (see comment here: #19513 (comment)) but I opt to keep this PR around until #19513 is merged.

Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

…3.19 -->> 3.19.2)

note: it's expected for build to fail
@dejan2609 dejan2609 changed the title KAFKA-19654 [WIP] test issues with GitHub actions builds <<--->> Develocity instance (for both trunk/Gradle 8 and attempted upgrade to Gradle 9) KAFKA-19707 [WIP] test issues with build scans failed to be published to Develocity instance (for both trunk/Gradle 8 and attempted upgrade to Gradle 9) Sep 14, 2025
@github-actions github-actions bot added the small Small PRs label Sep 14, 2025
…bumped (3.19 -->> 3.19.2)"

This reverts commit d930867.
…rsion (i.e. file `unixStartScript.txt`) was being referenced

(cherry picked from commit 9305e0b)
details:
 - gradle:       8.14.3 -->> 9.0.0
    - https://github.com/gradle/gradle/releases/tag/v9.0.0
    - https://gradle.org/whats-new/gradle-9
    - https://docs.gradle.org/9.0.0/userguide/upgrading_major_version_9.html#changes_major_9
 - shadow plugin: 8.3.6 -->> 9.0.2
    - https://github.com/GradleUp/shadow/releases/tag/9.0.0
    - https://github.com/GradleUp/shadow/releases/tag/9.0.1
    - https://github.com/GradleUp/shadow/releases/tag/9.0.2

refactoring (performed in order to accomodate Gradle 9 breaking changes):
 - tasks `siteDocsTar` and `releaseTarGz` are moved out of `core` (and into a new dummy module: `distribution`); note that distribution destination folder stays as-is (:core)
 - `preserveFileTimestamps` Tar taks property value explicitly set to `true` (default values: Gradle 8: `true`, Gradle 9: 'false')
 - files and folders permissions are introduced
 - git placeholder file (.gitkeep) is added in order to preserve `distribution` folder (Apache Rat check for that file is skipped)
 - `wrapper.gradle` changes: no need to check number of dots for Gradle versions >=9 anymore
 - redundant 'gradleVersion' ext property is removed (in favor of 'versions.gradle' usage)

(cherry picked from commit 14203aa)
… dependencies/plugins and GitHub Actions

details:
 - `setup-gradle` GitHub Action: 4.3.0 -->> 4.4.3 (note: this version was tested against Gradle 9)
 - grgit: 4.1.1 -->> 5.3.0
 - gradle versions plugin: 0.48.0 -->> 0.52.0
 - owasp dependency check : 8.2.1 -->> 12.1.3
 - spotbugs: 6.2.3  -->> 6.2.5
 - spotless: 6.25.0 -->> 7.2.1
 - Zinc Scala compiler: 1.9.2 -->> 1.10.8
(cherry picked from commit d01ace0)
…hen no test are discovered (i.e. solution for KAFKA-16801 is expanded)

(cherry picked from commit f0946db)
…adle.develocity` plugin version same as in trunk: 3.19)

note: it's expected for build to pass (i.e. build scans will be published and available on Develocity instance)
@github-actions github-actions bot removed the small Small PRs label Sep 14, 2025
…3.19 -->> 3.19.2)

note: it's expected for build to fail
@dejan2609
Copy link
Contributor Author

Title is too long (over 120 characters); changing that.

@dejan2609 dejan2609 changed the title KAFKA-19707 [WIP] test issues with build scans failed to be published to Develocity instance (for both trunk/Gradle 8 and attempted upgrade to Gradle 9) KAFKA-19707 [WIP] can't upgrade Develocity Gradle plugin (for both Gradle 8 and Gradle 9) Sep 15, 2025
@dejan2609
Copy link
Contributor Author

dejan2609 commented Sep 15, 2025

As explained here this is not a bug so I will close this PR (and corresponding Kafka JIRA ticket).

Thank you @bigdaz 🤝

@dejan2609 dejan2609 closed this Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Gradle build or GitHub Actions ci-approved tools triage PRs from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants