-
Notifications
You must be signed in to change notification settings - Fork 14.6k
MINOR: Refactor CLI tools to use CommandLineUtils#maybePrintHelpOrVersion #20469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…aybePrintHelpOrVersion
Thanks for the PR. I see the same pattern in ReplicaVerificationTool.java, could you update it as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your review!
Trunk output:
Branch output:
|
Great. LGTM, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apalan60: LGTM.
Could you please merge the trunk to trigger CI?
@frankvicky |
Refactor help and version handling in command-line tools by replacing
duplicate code with
CommandLineUtils#maybePrintHelpOrVersion
.Reviewers: TengYao Chi [email protected], Ken Huang
[email protected], Jhen-Yung Hsu [email protected], Chia-Ping
Tsai [email protected]