KAFKA-18711: Move DelegationTokenPublisher to metadata module #20475
+103
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: see-quick <[email protected]> # Conflicts: # core/src/main/scala/kafka/server/BrokerServer.scala # metadata/src/main/java/org/apache/kafka/metadata/publisher/ScramPublisher.java # server-common/src/main/java/org/apache/kafka/security/CredentialProvider.java # server-common/src/main/java/org/apache/kafka/server/common/CredentialProvider.java # server/src/main/java/org/apache/kafka/security/CredentialProvider.java
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
see-quick
force-pushed
the
delegation-token-publisher-refactor
branch
from
a3f263a to
18e2e68
Compare
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, one of the refactor tasks. In this PR, I have moved
DelegationTokenPublisherto the metadata module. Similar to theScramPublishermigration (commit feee50f), I have movedDelegationTokenManagerto the server-common module, as it would otherwise create a circular dependency. Moreover, I have made multiple changes throughout the codebase to referenceDelegationTokenManagerfrom server-common instead of the server module.P.S.: This is based on the ScramPublisher branch, so I would need to rebase when it is merged (that's why it is in draft).