MINOR: Followup KAFKA-19112 document updated #20492
Open
+51
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1a2st
changed the title
github-actions
bot
added
storage
chia7712
reviewed
Sep 6, 2025
| local log segments will be cleaned based on the values of <code>log.local.retention.bytes</code> and | ||
| <code>log.local.retention.ms</code>. | ||
| <br> | ||
| Note that <code>cleanup.policy</code> supports empty values, which means infinite retention. |
There was a problem hiding this comment.
We could remind users that this use case is equivalent to setting retention.ms=-1 and retention.bytes=-1
chia7712
reviewed
Sep 8, 2025
| @@ -1658,7 +1658,7 @@ class Partition(val topicPartition: TopicPartition, | |||
| def deleteRecordsOnLeader(offset: Long): LogDeleteRecordsResult = inReadLock(leaderIsrUpdateLock) { | |||
| leaderLogIfLocal match { | |||
| case Some(leaderLog) => | |||
| if (!leaderLog.config.delete) | |||
| if (!leaderLog.config.delete && leaderLog.config.compact) | |||
There was a problem hiding this comment.
Please add tests for this behavior change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sections are not very clear, and we need to update the
documentation.