KAFKA-19666: Remove old restoration codepath from RestoreIntegrationTest [4/N]

[shashankhs11]

Clean up RestoreIntegrationTest.java

Reviewers: Lucas Brutschy [email protected]

[Copilot]

Pull Request Overview

This PR cleans up integration tests related to state-updater by removing the state-updater parameterization from test methods in RestoreIntegrationTest.java. The changes simplify the test structure by removing the state-updater enabled/disabled testing matrix while maintaining coverage for the new protocol parameter.

• Removed state-updater parameterization from all test methods
• Simplified test method signatures and property configuration
• Cleaned up unused imports related to state-updater configuration

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

[nitpick] The props() method now creates an empty map which might be confusing. Consider adding a comment explaining that this method creates default properties without additional state-updater configuration, or rename it to defaultProps() for clarity.

Suggested change

	private Properties props() {
	/**
	* Creates default properties for a Streams application without additional state-updater configuration.
	*/
	private Properties defaultProps() {

[apalan60]

@shashankhs11

Thanks for the patch.
Overall LGTM, just a small nit.

[apalan60]

Nit: I noticed a few repeated snippets like

if (useNewProtocol) {
        props.put(StreamsConfig.GROUP_PROTOCOL_CONFIG, GroupProtocol.STREAMS.name());
    }

Maybe it could be helpful to add small overloads

private Properties props(final boolean useNewProtocol) {
    return props(mkObjectProperties(mkMap()), useNewProtocol);
}

private Properties props(final Properties extraProperties, final boolean useNewProtocol) {
    final Properties streamsConfiguration = props(extraProperties);
    if (useNewProtocol) {
        streamsConfiguration.put(StreamsConfig.GROUP_PROTOCOL_CONFIG, GroupProtocol.STREAMS.name());
    }
    return streamsConfiguration;
}

Then call sites could just use props(useNewProtocol) or props(extra, useNewProtocol) to reduce the repeated if blocks.