Skip to content

Conversation

FreeAndNil
Copy link
Contributor

@FreeAndNil FreeAndNil commented Oct 24, 2022

The creation of the locking model instance is now deferred to ActivateOptions() so that defaultLockingModelType has an effect.

  • include pdb file in nuget package fpr better debugging experience

@fluffynuts Could you please review?

@fluffynuts
Copy link
Contributor

@FreeAndNil most of the changes here are whitespace, except:

  1. not setting m_lockingModel at line 1660
  2. working around pdb files not being in the nuget package

I'm not 100% sure we want to expand the package size with the pdbs, considering the audience size of log4net. I'm open to be convinced here though (personally, since I use Rider, I can decompile any external sources enough to debug with, so pdbs have been of limited value). Please revert all the other files so that the impact is kept smaller.

@FreeAndNil FreeAndNil force-pushed the Feature/LockingModel branch from bb48e8b to 702184c Compare October 24, 2022 13:01
@FreeAndNil
Copy link
Contributor Author

Hi @fluffynuts,

i've reverted all the spacing changes.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants