Skip to content

[bugfix] copy native text index during format conversion #14172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[bugfix] copy native text index during format conversion #14172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...rg/apache/pinot/segment/local/segment/index/converter/SegmentV1V2ToV3FormatConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ private void copyIndexData(File v2Directory, SegmentMetadataImpl v2Metadata, Fil
copyLuceneTextIndexIfExists(v2Directory, v3Directory);
copyVectorIndexIfExists(v2Directory, v3Directory);
copyStarTreeV2(v2Directory, v3Directory);
copyNativeTextIndexIfExists(v2Directory, v3Directory);
}

private List<IndexType<?, ?, ?>> sortedIndexTypes() {
Expand Down Expand Up @@ -281,6 +282,15 @@ public boolean accept(File dir, String name) {
}
}

private void copyNativeTextIndexIfExists(File segmentDirectory, File v3Dir) throws IOException {
String suffix = V1Constants.Indexes.NATIVE_TEXT_INDEX_FILE_EXTENSION;
File[] textIndexFiles = segmentDirectory.listFiles((dir, name) -> name.endsWith(suffix));
for (File textIndexFile : textIndexFiles) {
File v3TextIndexFile = new File(v3Dir, textIndexFile.getName());
Files.copy(textIndexFile.toPath(), v3TextIndexFile.toPath());
}
}

private void deleteStaleConversionDirectories(File segmentDirectory) {
final String prefix = segmentDirectory.getName() + V3_TEMP_DIR_SUFFIX;
File[] files = segmentDirectory.listFiles(new FilenameFilter() {
Expand Down
Loading