Skip to content

Conversation

Jackie-Jiang
Copy link
Contributor

This was introduced in #14150 where _forwardIndexDisabledColumns is no longer extracted in IndexLoadingConfig

Fix the behavior in BaseDefaultColumnHandler to use the standard way to create forward index config

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.81%. Comparing base (59551e4) to head (92da172).
Report is 1177 commits behind head on master.

Files with missing lines Patch % Lines
...loader/defaultcolumn/BaseDefaultColumnHandler.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14215      +/-   ##
============================================
+ Coverage     61.75%   63.81%   +2.06%     
- Complexity      207     1535    +1328     
============================================
  Files          2436     2623     +187     
  Lines        133233   144421   +11188     
  Branches      20636    22099    +1463     
============================================
+ Hits          82274    92158    +9884     
- Misses        44911    45471     +560     
- Partials       6048     6792     +744     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.75% <66.66%> (+2.04%) ⬆️
java-21 63.70% <66.66%> (+2.08%) ⬆️
skip-bytebuffers-false 63.79% <66.66%> (+2.04%) ⬆️
skip-bytebuffers-true 63.67% <66.66%> (+35.94%) ⬆️
temurin 63.81% <66.66%> (+2.06%) ⬆️
unittests 63.80% <66.66%> (+2.06%) ⬆️
unittests1 55.54% <0.00%> (+8.65%) ⬆️
unittests2 34.32% <66.66%> (+6.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 095c166 into apache:master Oct 14, 2024
19 of 21 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_forward_index_disabled_default_column branch October 14, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants