WICKET-6941 Add visible attribute to AbstractColumn to hide/show columns in DataTable/DataGridView #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mns in DataTable/DataGridView.
reiern70
reviewed
Dec 30, 2021
| void populateItem(final Item<ICellPopulator<T>> cellItem, final String componentId, | ||
| final IModel<T> rowModel); | ||
|
|
||
| boolean isVisible(); |
There was a problem hiding this comment.
I would prefer this to be be
default boolean isVisible() {
return true;
}
and no setter.
|
|
||
| boolean isVisible(); | ||
|
|
||
| void setVisible(boolean visible); |
There was a problem hiding this comment.
As said I would prefer this to be only read-only
| } | ||
|
|
||
| @Override | ||
| public boolean isVisible() |
|
|
||
| private final S sortProperty; | ||
|
|
||
| private boolean visible = true; |
There was a problem hiding this comment.
See comment about read only
| for (IColumn<T, S> column : table.getColumns()) | ||
| { | ||
| columnsModels.add(Model.of(column)); | ||
| if (column.isVisible()) |
There was a problem hiding this comment.
I'm not sure this is the only involved toolbar that needs to be fixed... Did you run
mvn clean install
?
|
And thanks for your work :-) |
|
Close/reopen to re-trigger the build checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about the change to the interface ICellPopulator whether it is allowed in a minor version update.