[ZEPPELIN-6325] Add Custom TSLint Rule to Alphabetically Order Exports in public-api.ts #5071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbonelee
reviewed
Sep 14, 2025
|
Could you rebase this onto master branch? |
dididy
force-pushed
the
test/orderedExports
branch
from
dca16d4 to
1d73b3c
Compare
tbonelee
approved these changes
Sep 18, 2025
tbonelee
pushed a commit
that referenced
this pull request
Sep 18, 2025
…s in public-api.ts ### What is this PR for? #5065 (comment) In #5065, it was suggested that keeping exports sorted alphabetically would improve readability and consistency. TSLint does not provide a built-in rule for this (only `ordered-imports` exists for imports). Therefore, following the approach from #5053, I added a custom TSLint rule to enforce alphabetical ordering for exports. Applying this rule across the entire codebase would introduce many disruptive changes, so for now it is scoped only to the **public-api.ts** file. ### What type of PR is it? Improvement ### Todos ### What is the Jira issue? * [[ZEPPELIN-6325](https://issues.apache.org/jira/browse/ZEPPELIN-6325)] ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? N * Is there breaking changes for older versions? N * Does this needs documentation? N Closes #5071 from dididy/test/orderedExports. Signed-off-by: ChanHo Lee <[email protected]> (cherry picked from commit 8d18618) Signed-off-by: ChanHo Lee <[email protected]>
|
Thanks, merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
#5065 (comment)
In #5065, it was suggested that keeping exports sorted alphabetically would improve readability and consistency.
TSLint does not provide a built-in rule for this (only
ordered-importsexists for imports). Therefore, following the approach from #5053, I added a custom TSLint rule to enforce alphabetical ordering for exports.Applying this rule across the entire codebase would introduce many disruptive changes, so for now it is scoped only to the public-api.ts file.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: