ZOOKEEPER-4970: Deprecate ZKConfig methods which throw QuorumPeerConfig.ConfigException #2309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ig.ConfigException `QuorumPeerConfig` belongs to and ties with other server code. To separate a slimmer `zookeeper-client` jar, we have to break the dependency from `ZKConfig` to `QuorumPeerConfig`. But this is a breaking change, it would be good to deprecate these methods first to ease future migration. Refs: ZOOKEEPER-4966, ZOOKEEPER-4970, ZOOKEEPER-233.
kezhuw
force-pushed
the
ZOOKEEPER-4970-deprecate-ConfigException-from-ZKConfig
branch
from
eb9421f to
1985e82
Compare
Maybe we can instead create a But Java has no re-export or force bundle deps. So it's still a break .. I mean, how can we properly mark a class would be located in the future client/server module, so that we don't introduce an unexpected dependency later. |
|
OK. I see #2307 now. So just go for 4.0 :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuorumPeerConfigbelongs to and ties with other server code. To separate a slimmerzookeeper-clientjar, we have to break the dependency fromZKConfigtoQuorumPeerConfig. But this is a breaking change, it would be good to deprecate these methods first to ease future migration.Refs: ZOOKEEPER-4966, ZOOKEEPER-4970, ZOOKEEPER-233.