Skip to content

Alternative fix to #2643: allow autowiring of filter classes #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2019
Merged

Alternative fix to #2643: allow autowiring of filter classes #2664

merged 1 commit into from
Mar 29, 2019

Conversation

meyerbaptiste
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #2643 (comment)
License MIT
Doc PR n/a

@meyerbaptiste meyerbaptiste force-pushed the fix_filters_autowiring branch from 8c0c461 to 8f19fa5 Compare March 27, 2019 16:47
teohhanhui
teohhanhui reviewed Mar 28, 2019
View reviewed changes
@meyerbaptiste meyerbaptiste force-pushed the fix_filters_autowiring branch 3 times, most recently from cebf4b8 to 9422779 Compare March 29, 2019 00:57
@meyerbaptiste
Copy link
Member Author

Done! 😃

@meyerbaptiste meyerbaptiste force-pushed the fix_filters_autowiring branch from 9422779 to 7608858 Compare March 29, 2019 00:59
@teohhanhui teohhanhui merged commit 37f25a3 into api-platform:2.4 Mar 29, 2019
@teohhanhui
Copy link
Contributor

Thanks @meyerbaptiste! 🎉 🚀

@meyerbaptiste meyerbaptiste deleted the fix_filters_autowiring branch April 1, 2019 09:19
@teohhanhui teohhanhui mentioned this pull request Apr 10, 2019
Merged
@karser karser mentioned this pull request May 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@teohhanhui teohhanhui teohhanhui approved these changes

@antograssiot antograssiot antograssiot approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meyerbaptiste @teohhanhui @antograssiot