feat: add list kv store keys by collection or prefix #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MFori
added
the
t-console
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for listing key-value store keys by collection or prefix. The updates include modifications to both the synchronous and asynchronous versions of the list_keys function to accept additional query parameters, "collection" and "prefix".
- Added "collection" and "prefix" parameters in the list_keys methods
- Updated the docstrings to reflect the new parameters
Comments suppressed due to low confidence (2)
src/apify_client/clients/resource_clients/key_value_store.py:71
- Consider adding tests to validate the behavior of the new 'collection' parameter, ensuring it is correctly processed by the API.
collection: str | None = None,
src/apify_client/clients/resource_clients/key_value_store.py:72
- Consider adding tests to validate the behavior of the new 'prefix' parameter, ensuring it is correctly processed by the API.
prefix: str | None = None,
vdusek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
collectionandprefixquery params for listing key-value store keys based on https://github.com/apify/actor-whitepaper/blob/master/pages/KEY_VALUE_STORE_SCHEMA.md#api-implicationsApi docs: apify/apify-docs#1564
Api impl: https://github.com/apify/apify-core/pull/20726