Skip to content

Conversation

protoss70
Copy link
Contributor

Renamed option for sortBy parameter from "lastRunStartedAt" to "stats.lastRunStartedAt" to fit the TICKET specifications. Will merge when the apify-core PR is deployed

@protoss70 protoss70 requested review from drobnikj and vdusek June 23, 2025 17:43
@protoss70 protoss70 self-assigned this Jun 23, 2025
@protoss70 protoss70 added the t-integrations Issues with this label are in the ownership of the integrations team. label Jun 23, 2025
@protoss70 protoss70 marked this pull request as ready for review June 25, 2025 08:20
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek changed the title fix: Renamed sortBy parameters option fix: Rename sortBy parameters option Jun 25, 2025
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@protoss70 Just a quick note, the first word of the PR title after the conventional commit type, should be a verb in imperative form. We do render changelogs from the commit titles. So I've updated the title 🙂.

Copy link
Member

@drobnikj drobnikj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@protoss70 protoss70 merged commit a270409 into master Jun 26, 2025
29 checks passed
@protoss70 protoss70 deleted the fix/renamed-option-for-sortBy-parameter branch June 26, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-integrations Issues with this label are in the ownership of the integrations team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants