WIP: feat: Abstract away boilerplate code to apify-mcp-sdk #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirispilka
changed the title
|
Nice, I really like the simple API, this will make it simpler to build for the users and maintain for us 👍 I would also add a way for advanced users to defined a custom charge function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an initial draft of how we could make our lives easier by moving repetitive code into a shared package or SDK.
The package would be either standalone at pypi and npm or included in apify sdk
I’m not 100% sure it’s worth it, there would be some maintenance cost, but it could make maintaining Actors much easier in the long run.
Please just take a look. No need for a thorough review yet; this is open for discussion.
FYI @ivanvia7 @MQ37 @MichalKalita @MatousMarik