Skip to content

Use regular if/else to avoid Int boxing #6688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2025
Merged

Use regular if/else to avoid Int boxing #6688

merged 1 commit into from
Aug 30, 2025

Conversation

JakeWharton
Copy link
Contributor

See https://kotlin.godbolt.org/z/rTbGfbGz3 for the bytecode of the old approach to see the boxing in action.

martinbonnin
martinbonnin approved these changes Aug 30, 2025
View reviewed changes
Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thanks!

@martinbonnin martinbonnin merged commit b6b4514 into apollographql:main Aug 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbonnin martinbonnin martinbonnin approved these changes

@BoD BoD Awaiting requested review from BoD BoD is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakeWharton @martinbonnin