Skip to content

Implement Protocol-Based Testing with Sendable Conformance in AppStoreServerAPIClient #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Implement Protocol-Based Testing with Sendable Conformance in AppStoreServerAPIClient #91

wants to merge 7 commits into from

Conversation

StefanPrintezis
Copy link

@StefanPrintezis StefanPrintezis commented Jun 20, 2025 •
edited
Loading

Summary

This PR implements a protocol-based testing approach inspired by Soto's AWSHTTPClient pattern, making AppStoreServerAPIClient conform to Sendable, and improves the overall architecture for better testability and concurrency safety.

Protocol-Based HTTP Client Architecture

  • Added AppStoreHTTPClient protocol for abstracting HTTP operations
  • Made HTTPClient conform to AppStoreHTTPClient by extension
  • Updated AppStoreServerAPIClient to accept any AppStoreHTTPClient for dependency injection & sharing the http pool
  • Exposed httpClient through initializer with HTTPClient.shared as default so we share the http pool by default
  • Removed manual deinit since HTTP client lifecycle is now managed externally

Configuration Improvements

  • Created AppStoreServerAPIConfiguration struct for centralized configuration management
  • Added throwing configuration initializer for better error handling
  • Non-throwing client initializer for cleaner API usage

Testing

  • Implemented MockHTTPClient for unit testing, since we couldn't extend the final Sendable class anymore
  • Updated test suite to use protocol-based mocking instead of inheritance

Documentation Updates

  • Updated README to use new configuration-based syntax
  • Fixed variable name inconsistencies in code examples

@StefanPrintezis
Conform AppStoreServerAPIClient to Sendable by making the class final
4955478 
Instead of initializing a http client pool, expose the httpClient through the initializer or default on .shared that way we can share the http pool with others
Deinit is no longer needed since httpclient is exposed
Create a configuration struct so we are able to throw when initializing config & have a non throwing client initializer
@StefanPrintezis
Instead of extending the client use a mocked http client to handle un…
b70823b 
…it tests, since AppStoreServerAPIClient is a final Sendable class now
@StefanPrintezis
Update readme to use the new configuration struct
f032c55
@StefanPrintezis
Use modern initialization syntax in readme for transactionHistoryRequest
0161db2
@StefanPrintezis
Fix variable name inconsistency in readme.md
65104d8
@StefanPrintezis StefanPrintezis changed the title Sp/sendable client Implement Protocol-Based Testing with Sendable Conformance in AppStoreServerAPIClient Jun 20, 2025
@StefanPrintezis StefanPrintezis marked this pull request as ready for review June 20, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderjordanbaker alexanderjordanbaker Awaiting requested review from alexanderjordanbaker

1 more reviewer

@Joannis Joannis Joannis left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanPrintezis @Joannis