Skip to content

feat: add sigterm handling for graceful termination #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: add sigterm handling for graceful termination #1324

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4f9e38
Merge pull request #1321 from Edwinhr716:lws-integration
changlan Jul 28, 2025
6e02555
feat: add sigterm handling for graceful termination
linxiulei Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions axlearn/common/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,7 @@ def __init__(
model=self.model,
model_param_partition_specs=model_param_partition_specs,
)
register_sigterm_handler()
self._maybe_record_event(measurement.Event.END_ACCELERATOR_INIT)

@property
Expand Down Expand Up @@ -1450,3 +1451,13 @@ def m_or_g(x, suffix=""):
logging.warning("Attempt to parse cost_stats=%s but failed.", cost_stats)

return analysis_results

def register_sigterm_handler():
original_sigterm_handler = signal.getsignal(signal.SIGTERM)
def sigterm_handler(signum, frame):
original_sigterm_handler(signum, frame)

# system is being shutdown
if os.path.exists("/var/run/nologin") or os.path.exists("/run/nologin"):
raise SystemExit("Exiting without waiting checkpoint saving after system shutdown is detected.")
signal.signal(signal.SIGTERM, sigterm_handler)