Skip to content

chore: replace wasm-pack with wasm-bindgen-cli #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2025
+35 −299
Merged

chore: replace wasm-pack with wasm-bindgen-cli #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9b9eec
Remove wasm-pack
donghaoren Sep 2, 2025
568c31b
Use wasm-bindgen to generate the binding directly
donghaoren Sep 2, 2025
c066602
Fix
donghaoren Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ jobs:
with:
version: 4.0.13

- name: Setup Rust for WebAssembly
run: |
rustup target add wasm32-unknown-unknown
cargo install -f wasm-bindgen-cli --version 0.2.100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hardcoding the version here, can we use cargo to install dependencies?

Copy link
Collaborator Author

@donghaoren donghaoren Sep 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried putting it in Cargo.toml at first but that didn't work, if you figured it out feel free to send a new PR!


- name: Set up uv package manager
uses: astral-sh/setup-uv@v5

Expand Down
286 changes: 3 additions & 283 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading