Update Class and TypeAlias representation according to SPICE-0021 #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HT154
force-pushed
the
class-typealias-repr
branch
4 times, most recently
from
9396609 to
2dbc0b4
Compare
HT154
commented
Sep 18, 2025
There was a problem hiding this comment.
This PR moves the semver code into internal and makes things public so that tests in the pkl_test package can access this code. This is needed because unmarshal_test.go must be in pkl_test because it imports pkl-gen-go-generated code which imports the pkl package and that would be a circular import. Testing the new class/typealias encoding requires a version comparison to implement the correct assertions based on Pkl version.
HT154
force-pushed
the
class-typealias-repr
branch
from
2dbc0b4 to
81d88bb
Compare
HT154
changed the title
HT154
force-pushed
the
class-typealias-repr
branch
from
81d88bb to
bdb558b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements decoding changes for SPICE-0021
Pending adding Pkl 0.30 support in tests after release.