Expose collected superclass properties/methods in pkl:reflect
#1106
Conversation
pkl-core/src/test/files/LanguageSnippetTests/input/api/reflect4.pkl
Outdated
Show resolved
Hide resolved
HT154
force-pushed
the
reflect-all-properties-methods
branch
2 times, most recently
from
fae0f86 to
0d21d7d
Compare
| public VmTyped getMirror(VmClass clazz) { | ||
| return MirrorFactories.propertyFactory.create(new Mirror(this, clazz)); | ||
| } |
There was a problem hiding this comment.
I'm not sure how to derive allAnnotations/allModifiers without somehow "currying" the VmClass into the mirror for the ClassProperty. If you've got any better ideas here, I'm all ears!
HT154
force-pushed
the
reflect-all-properties-methods
branch
2 times, most recently
from
e1c24e7 to
b4e49f1
Compare
|
|
||
| /// The annotations of this module, appended with any from the containing class's superclasses. | ||
| /// | ||
| /// Annotations are ordered starting with the current class and walking up the class hierarchy. |
There was a problem hiding this comment.
You mentioned the order here, but allProperties/Methods/Modifiers also follow the same rule right?
There was a problem hiding this comment.
I'm a little concerned with defining behavior for allProperties/allMethods because those are implemented in terms of the existing VmClass.collectAll(Properties|Methods) methods and iteration order isn't well-defined for them.
This also isn't applicable for allModifiers because the implementation builds the bitset with bitwise OR and calls VmModifier.getMirrors, which has a stable order for elements based on bits set.
HT154
force-pushed
the
reflect-all-properties-methods
branch
from
b4e49f1 to
44693f7
Compare
HT154
force-pushed
the
reflect-all-properties-methods
branch
from
44693f7 to
53d5405
Compare
No description provided.