Change outs from string_list to output_list
#10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow using the `outs` produced by `pkl_eval` as inputs to other rules.
KushalP
commented
Jul 12, 2024
| @@ -1 +1 @@ | |||
| tests/pkl_eval/pkl_eval_with_out/helloworld.pcf | |||
| tests/pkl_eval/helloworld.pcf | |||
There was a problem hiding this comment.
I'm not sure if removing the intermediary directories is an issue here. I would appreciate feedback on this.
There was a problem hiding this comment.
It's backward incompatible but I support this change:
- when
outsis specified, then I strongly prefer not namespacing with a directory (otherwise it's confusing to the user: they specify a path that looks relative to the Bazel package dir and would end up with a different path) - when
outsis unspecified withmultiple_outputs = False, there's already namespacing going on via the file name - when
outsis unspecified withmultiple_outputs = True, namespacing is still happening via a directory.
For context, initially, the rationale for a namespacing directory was to keep every case above consistent (they would all be under a namespaced directory) but taking a step back, the suggested approach has more benefits.
KushalP
commented
Jul 12, 2024
sitaktif
reviewed
Jul 15, 2024
Otherwise we'll find that the common prefix of `[somedir/two, somedir/three]` is `somedir/t`.
Writing this test case produced caused the previous implementation to fail. After spending some time debugging it, I realised that the `output_location` for multiple defined `outs` can be simplified to just use the `genfiles_dir` concatenated with the `label.package`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow using the
outsproduced bypkl_evalas inputs to other rules.