-
Notifications
You must be signed in to change notification settings - Fork 20
Make MMIO
buildable for WASI (exclude ShellCommand.swift
)
#134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Neither `Dispatch` nor `Process` are available for WASI. To make this module buildable, code in `ShellCommand.swift` needs to be excluded.
Aside from the abysmal issue of dispatch on linux crashing all the time, I'd like to make sure we have ci for any new platforms this repo intends to support, what might that look like for wasi? |
Since there's no 1st-party Swift SDK for WASI, we can't set up a CI for it and support for WASI can only be tested locally. |
how does one test it locally? |
The only way I know of is to get a Swift SDK from SwiftWasm and build with that. |
What SDK content do you expect would be need? the primary MMIO library has no libc dependency, unless I accidentally re-introduced one. |
IIUC no Swift SDK for WASI content is needed for MMIO per se. But packages built for WASI depending on MMIO would have to build MMIO for WASI too, because currently there can be only one target platform for the whole build graph in SwiftPM. |
Since |
@MaxDesiatov is this still needed? I've moved ShellCommand out of MMIOUtilities. |
Even if it were moved out to a separate module, |
This code is only in test targets that doesn't run on the embedded targets anyways now |
Neither
Dispatch
norProcess
are available on WASI. To make this module buildable, code inShellCommand.swift
needs to be excluded.Checklist
- [ ] I've updated the documentation if necessary- [ ] I've added at least one test that validates that my change is working, if appropriate