Skip to content

fix-1392-Inconsistency-in-User-Verification-Status #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix-1392-Inconsistency-in-User-Verification-Status #2112

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6da4bf8
Bug that was fixed:
MicahHeneveld Jul 11, 2025
4afc0e0
Merge branch 'appwrite:main' into fix-1392-Inconsistency-in-User-Veri…
anthonythang1 Aug 12, 2025
10b60f1
updated user status to consider name empty/exists
anthonythang1 Aug 12, 2025
daa59f1
User verification status inconsistency fix
MicahHeneveld Aug 20, 2025
07632bd
fix User verification status inconsistency issue 1392
MicahHeneveld Aug 20, 2025
3f73161
fix-1392-Inconsistency-in-User-Verification-Status update
MicahHeneveld Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/routes/(console)/project-[region]-[project]/auth/user-[user]/updateStatus.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,12 @@
.forProject(page.params.region, page.params.project)
.users.updateEmailVerification($user.$id, !$user.emailVerification);
await invalidate(Dependencies.USER);

addNotification({
message: `${$user.name || $user.email || $user.phone || 'The account'} has been ${
!$user.emailVerification ? 'unverified' : 'verified'
message: `${
$user.name && $user.name.trim() !== ''
? `The email for ${$user.name} ${!$user.emailVerification ? 'is no longer verified' : 'has been verified'}`
: `The email ${!$user.emailVerification ? 'is no longer verified' : 'has been verified'}`
}`,
Comment on lines +27 to 31
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Stabilize message against timing/race; base it on the intended new state, not the reactive store.

Right after invalidate(), $user may still momentarily reflect the previous value. Build the message from a local nextEmail computed before/with the API call to avoid inverted alerts.

Apply this diff to simplify and de-duplicate the string logic:

-                message: `${
-                    $user.name && $user.name.trim() !== ''
-                        ? `The email for ${$user.name} ${!$user.emailVerification ? 'is no longer verified' : 'has been verified'}`
-                        : `The email ${!$user.emailVerification ? 'is no longer verified' : 'has been verified'}`
-                }`,
+                message: `${displayName ? `The email for ${displayName}` : 'The email'} ${nextEmail ? 'has been verified' : 'is no longer verified'}`,

Add these lines inside updateVerificationEmail() (outside the changed hunk) to define and use stable values:

const nextEmail = !$user.emailVerification;
const displayName = $user.name?.trim() || '';
await sdk.forProject(page.params.region, page.params.project).users.updateEmailVerification($user.$id, nextEmail);

Optionally confirm copy choice: do we prefer “is no longer verified” or “has been unverified” for consistency with button text?

🏁 Script executed:

#!/bin/bash
# Locate and inspect the updateStatus.svelte component to verify message construction and API call timing
file=$(fd -e svelte updateStatus.svelte)
sed -n '1,80p' "$file"

Length of output: 1076

🏁 Script executed:

#!/bin/bash
# Focus on the auth user updateStatus component
FILE=$(fd -e svelte updateStatus.svelte | grep '/auth/user-')
echo "Inspecting $FILE"
grep -n 'updateVerificationEmail' "$FILE" || true
echo "--- beginning of file ---"
sed -n '1,200p' "$FILE"

Length of output: 8976

Stabilize and simplify the success message in updateVerificationEmail by computing nextEmail and displayName before the API call and using them in addNotification; apply the same pattern to updateVerificationPhone.

--- a/src/routes/(console)/project-[region]-[project]/auth/user-[user]/updateStatus.svelte
@@ async function updateVerificationEmail() {
-    await sdk
-        .forProject(page.params.region, page.params.project)
-        .users.updateEmailVerification($user.$id, !$user.emailVerification);
+    const nextEmail = !$user.emailVerification;
+    const displayName = $user.name?.trim() || '';
+    await sdk
+        .forProject(page.params.region, page.params.project)
+        .users.updateEmailVerification($user.$id, nextEmail);

@@
-    addNotification({
-        message: `${
-            $user.name && $user.name.trim() !== ''
-                ? `The email for ${$user.name} ${!$user.emailVerification ? 'is no longer verified' : 'has been verified'}`
-                : `The email ${!$user.emailVerification ? 'is no longer verified' : 'has been verified'}`
-        }`,
-        type: 'success'
-    });
+    addNotification({
+        message: `${displayName ? `The email for ${displayName}` : 'The email'} ${nextEmail ? 'has been verified' : 'is no longer verified'}`,
+        type: 'success'
+    });

Apply an equivalent change in updateVerificationPhone() using const nextPhone = !$user.phoneVerification and displayName before its API call.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
message: `${
$user.name && $user.name.trim() !== ''
? `The email for ${$user.name} ${!$user.emailVerification ? 'is no longer verified' : 'has been verified'}`
: `The email ${!$user.emailVerification ? 'is no longer verified' : 'has been verified'}`
}`,
--- a/src/routes/(console)/project-[region]-[project]/auth/user-[user]/updateStatus.svelte
@@ async function updateVerificationEmail() {
- await sdk
- .forProject(page.params.region, page.params.project)
const nextEmail = !$user.emailVerification;
const displayName = $user.name?.trim() || '';
await sdk
.forProject(page.params.region, page.params.project)
.users.updateEmailVerification($user.$id, nextEmail);
@@
- addNotification({
- message: `${
- $user.name && $user.name.trim() !== ''
- ? `The email for ${$user.name} ${!$user.emailVerification ? 'is no longer verified' : 'has been verified'}`
- : `The email ${!$user.emailVerification ? 'is no longer verified' : 'has been verified'}`
- }`,
- type: 'success'
addNotification({
message: `${displayName ? `The email for ${displayName}` : 'The email'} ${
nextEmail ? 'has been verified' : 'is no longer verified'
}`,
type: 'success'
});
🤖 Prompt for AI Agents 
In
src/routes/(console)/project-[region]-[project]/auth/user-[user]/updateStatus.svelte
around lines 27 to 31, the success notification builds the message inline using
$user values after the API call; compute const nextEmail =
!$user.emailVerification and const displayName = $user.name && $user.name.trim()
!== '' ? $user.name : $user.email before making the updateVerificationEmail API
call, then pass those precomputed values into addNotification (use nextEmail to
decide "has been verified" vs "is no longer verified" and displayName for the
name/email shown). Apply the same pattern in updateVerificationPhone(): define
const nextPhone = !$user.phoneVerification and reuse a precomputed displayName
before the phone API call and in addNotification.

type: 'success'
});
Expand All @@ -44,9 +47,12 @@
.forProject(page.params.region, page.params.project)
.users.updatePhoneVerification($user.$id, !$user.phoneVerification);
await invalidate(Dependencies.USER);

addNotification({
message: `${$user.name || $user.email || $user.phone || 'The account'} has been ${
$user.phoneVerification ? 'unverified' : 'verified'
message: `${
$user.name && $user.name.trim() !== ''
? `The phone for ${$user.name} ${!$user.phoneVerification ? 'is no longer verified' : 'has been verified'}`
: `The phone ${!$user.phoneVerification ? 'is no longer verified' : 'has been verified'}`
}`,
Comment on lines +52 to 56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Mirror the same robustness for phone verification messages.

Use a stable nextPhone rather than reading from $user after invalidation to prevent occasional mismatches.

Apply this diff:

-                message: `${
-                    $user.name && $user.name.trim() !== ''
-                        ? `The phone for ${$user.name} ${!$user.phoneVerification ? 'is no longer verified' : 'has been verified'}`
-                        : `The phone ${!$user.phoneVerification ? 'is no longer verified' : 'has been verified'}`
-                }`,
+                message: `${displayName ? `The phone for ${displayName}` : 'The phone'} ${nextPhone ? 'has been verified' : 'is no longer verified'}`,

Add these lines inside updateVerificationPhone() (outside the changed hunk):

const nextPhone = !$user.phoneVerification;
const displayName = $user.name?.trim() || '';
await sdk.forProject(page.params.region, page.params.project).users.updatePhoneVerification($user.$id, nextPhone);

🏁 Script executed:

#!/bin/bash
# Locate updateStatus.svelte
file=$(fd updateStatus.svelte -t f)
echo "File found: $file"

# Show context around the message snippet
rg -nC3 'message:' "$file"

# Search for updateVerificationPhone usage
rg -nC2 'updateVerificationPhone' "$file"

# Search for displayName and nextPhone declarations
rg -nE 'displayName|nextPhone' -nC2 "$file"

Length of output: 3264

🏁 Script executed:

#!/bin/bash
# Target the auth user updateStatus.svelte file
file=$(fd -e svelte updateStatus.svelte | grep 'auth/user' | head -n1)
echo "Using file: $file"

# Show the message block context
rg -nC3 'message:' "$file"

# Locate updateVerificationPhone function definition and calls
rg -nC3 'updateVerificationPhone' "$file"

# Check for existing displayName or nextPhone variables
rg -nC3 'displayName' "$file"
rg -nC3 'nextPhone' "$file"

Length of output: 4017

🏁 Script executed:

#!/bin/bash
# Find the auth user updateStatus.svelte file
file=$(fd -e svelte updateStatus.svelte | grep 'auth/user' | head -n1)
echo "Inspecting: $file"

# Print the first 200 lines to view updateVerificationPhone and related context
sed -n '1,200p' "$file"

Length of output: 8576

Use local nextPhone and displayName in updateVerificationPhone
– Inside async function updateVerificationPhone() (in src/routes/(console)/project-[region]-[project]/auth/user-[user]/updateStatus.svelte), add at the top:

const nextPhone = !$user.phoneVerification;
const displayName = $user.name?.trim() || '';

– Replace the SDK call to use nextPhone:

- await sdk
-     .forProject(page.params.region, page.params.project)
-     .users.updatePhoneVerification($user.$id, !$user.phoneVerification);
+ await sdk
+     .forProject(page.params.region, page.params.project)
+     .users.updatePhoneVerification($user.$id, nextPhone);

– Update the success notification to:

addNotification({
  message: `${displayName ? `The phone for ${displayName}` : 'The phone'} ${nextPhone ? 'has been verified' : 'is no longer verified'}`,
  type: 'success'
});

This ensures the message and API call consistently use the intended new verification state.

🤖 Prompt for AI Agents 
In
src/routes/(console)/project-[region]-[project]/auth/user-[user]/updateStatus.svelte
around lines 52 to 56, the updateVerificationPhone function should use local
variables for the intended new verification state and display name so the API
call and success notification are consistent; add at the top of that function:
const nextPhone = !$user.phoneVerification; const displayName =
$user.name?.trim() || ''; then change the SDK call to use nextPhone (not
toggling or reading $user again) and update the addNotification message to use
displayName and nextPhone so the text reads either "The phone for {displayName}
has been verified" / "is no longer verified" or "The phone has been verified" /
"is no longer verified" accordingly.

type: 'success'
});
Expand Down