Skip to content

fix: add missing filter elements for status and providerType columns #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add missing filter elements for status and providerType columns #2331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/lib/components/filters/quickFilters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,13 @@ export function addFilterAndApply(
addSizeFilter(value, colId, columns);
} else if (colId === 'statusCode') {
addStatusCodeFilter(value, colId, columns);
} else if (colId === '$createdAt' || colId === '$updatedAt' || colId === 'buildDuration') {
} else if (
colId === '$createdAt' ||
colId === '$updatedAt' ||
colId === 'buildDuration' ||
colId === 'scheduledAt' ||
colId === 'deliveredAt'
) {
addDateFilter(value, colId, columns);
} else {
addFilter(columns, colId, operator, value, arrayValues);
Expand Down
7 changes: 6 additions & 1 deletion src/lib/components/filters/setFilters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@ export function setFilters(localTags: TagValue[], filterCols: FilterData[], $col
setSizeFilter(filter, $columns);
} else if (id?.includes('statuscode')) {
setStatusCodeFilter(filter, $columns);
} else if (id === '$createdat' || id === '$updatedat') {
} else if (
id === '$createdat' ||
id === '$updatedat' ||
id === 'scheduledat' ||
id === 'deliveredat'
) {
setDateFilter(filter, $columns);
} else {
setFilterData(filter);
Expand Down
54 changes: 50 additions & 4 deletions src/routes/(console)/project-[region]-[project]/messaging/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,56 @@
filter: false,
width: { min: 140 }
},
{ id: 'providerType', title: 'Type', type: 'string', width: { min: 100 } },
{ id: 'status', title: 'Status', type: 'string', width: { min: 120 } },
{ id: 'scheduledAt', title: 'Scheduled at', type: 'datetime', width: { min: 120 } },
{ id: 'deliveredAt', title: 'Delivered at', type: 'datetime', width: { min: 120 } }
{
id: 'providerType',
title: 'Type',
type: 'string',
width: { min: 100 },
array: true,
format: 'enum',
elements: [
{ value: 'email', label: 'Email' },
{ value: 'sms', label: 'SMS' },
{ value: 'push', label: 'Push' }
]
},
{
id: 'status',
title: 'Status',
type: 'enum',
width: { min: 120 },
array: true,
format: 'enum',
elements: ['draft', 'scheduled', 'processing', 'sent', 'failed']
},
{
id: 'scheduledAt',
title: 'Scheduled at',
type: 'datetime',
width: { min: 120 },
format: 'datetime',
elements: [
{ value: 5 * 60 * 1000, label: 'last 5 minutes' },
{ value: 60 * 60 * 1000, label: 'last 1 hour' },
{ value: 24 * 60 * 60 * 1000, label: 'last 24 hours' },
{ value: 7 * 24 * 60 * 60 * 1000, label: 'last 7 days' },
{ value: 30 * 24 * 60 * 60 * 1000, label: 'last 30 days' }
]
},
{
id: 'deliveredAt',
title: 'Delivered at',
type: 'datetime',
width: { min: 120 },
format: 'datetime',
elements: [
{ value: 5 * 60 * 1000, label: 'last 5 minutes' },
{ value: 60 * 60 * 1000, label: 'last 1 hour' },
{ value: 24 * 60 * 60 * 1000, label: 'last 24 hours' },
{ value: 7 * 24 * 60 * 60 * 1000, label: 'last 7 days' },
{ value: 30 * 24 * 60 * 60 * 1000, label: 'last 30 days' }
]
}
]);

const region = page.params.region;
Expand Down