Skip to content

Fix: Error updating row w/ many relationships [WIP] #2353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix: Error updating row w/ many relationships [WIP] #2353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c778711
fix: preferences fallback logic.
ItzNotABug Sep 11, 2025
e17ae66
add: relationship type on columns page cell.
ItzNotABug Sep 11, 2025
b3b1806
lint.
ItzNotABug Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/stores/preferences.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,8 @@ function createPreferences() {
loadTeamPrefs: loadTeamPreferences,

getDisplayNames: (tableId: string) => {
return teamPreferences?.displayNames?.[tableId] ?? ['$id'];
const names = teamPreferences?.displayNames?.[tableId];
return Array.isArray(names) && names.length > 0 ? names : ['$id'];
},

setDisplayNames: async (
Expand Down
4 changes: 3 additions & 1 deletion ...s/(console)/project-[region]-[project]/databases/database-[database]/subNavigation.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@
tables: []
});

const sortedTables = $derived.by(() => tables?.tables);
const sortedTables = $derived.by(() =>
tables?.tables?.slice().sort((a, b) => a.name.localeCompare(b.name))
);

const selectedTable = $derived.by(() =>
sortedTables?.find((table: Models.Table) => table.$id === tableId)
Expand Down
26 changes: 25 additions & 1 deletion ...oject-[region]-[project]/databases/database-[database]/table-[table]/columns/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,24 @@
}
}

function getRelationshipTypeForColumn(column: Columns): string | null {
if (!isRelationship(column)) {
return null;
}

const relationshipMap = {
oneToOne: 'One to one',
oneToMany: 'One to many',
manyToOne: 'Many to one',
manyToMany: 'Many to many'
};

const relationType = (column as Models.ColumnRelationship).relationType;
const formattedType = relationshipMap[relationType] || relationType;

return `Type: ${formattedType}`;
}

onDestroy(() => ($showCreateColumnSheet.show = false));

$effect(() => {
Expand Down Expand Up @@ -222,7 +240,6 @@
<Spreadsheet.Header.Cell column="actions" {root} />
</svelte:fragment>

<!-- TODO: variable and terminology changes -->
{#each updatedColumnsForSheet as column, index}
{@const option = columnOptions.find((option) => option.type === column.type)}
{@const isSelectable =
Expand Down Expand Up @@ -290,12 +307,19 @@
</Layout.Stack>
</Layout.Stack>
{@const minMaxSize = getMinMaxSizeForColumn(column)}
{@const relationType = getRelationshipTypeForColumn(column)}
{#if minMaxSize}
<Typography.Caption
variant="400"
color="--fgcolor-neutral-tertiary">
{minMaxSize}
</Typography.Caption>
{:else if relationType}
<Typography.Caption
variant="400"
color="--fgcolor-neutral-tertiary">
{relationType}
</Typography.Caption>
{/if}
</Layout.Stack>
</Spreadsheet.Cell>
Expand Down