-
Notifications
You must be signed in to change notification settings - Fork 187
Fix: related table not loading #2389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ConsoleProject ID: Sites (2)
Note Appwrite has a Discord community with over 16 000 members. |
Walkthrough
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/columns/relationship.svelte (2)
141-152
: Good guard: stop search/fetch while editing. Add a runtime guard to the debounced fetch to avoid stale requests.If a fetch was already scheduled before
editing
flips true, it can still run. Add anediting
check inside the debounced function to no-op when editing toggles mid-debounce.Apply outside this hunk:
@@ -const debouncedFetchTables = debounce(async () => { - tableList = await getTables(); - // reset search - search = undefined; -}, 500); +const debouncedFetchTables = debounce(async () => { + if (editing) return; // bail if user is editing now + tableList = await getTables(); + // reset search only when not editing (handles race) + if (!editing) search = undefined; +}, 500);
142-144
: Prefer toLowerCase for ID matching.IDs are ASCII;
toLocaleLowerCase()
adds unnecessary locale semantics and overhead.-const exists = tableList?.tables?.some((c) => - c.$id.toLocaleLowerCase().includes(search.toLocaleLowerCase()) -); +const exists = tableList?.tables?.some((c) => + c.$id.toLowerCase().includes(search.toLowerCase()) +);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
package.json
(1 hunks)src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/columns/relationship.svelte
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: e2e
- GitHub Check: build
🔇 Additional comments (2)
src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/columns/relationship.svelte (1)
194-194
: Whitespace tweak is fine.package.json (1)
27-29
: Confirm Pink commits resolve and don’t introduce UI/API regressions.Both pink packages are now pinned to 4a33959 via pkg.vc. Please ensure the lockfile is refreshed and CI green after install, and that ComboBox behavior is unchanged except for the intended fix.
Run this quick check locally after a clean install to confirm the pins and surface any peer dep warnings:
What does this PR do?
Combo-box was setting the text to empty string, causing load issues.
Test Plan
Manual.
Before -
After -
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)
Summary by CodeRabbit
New Features
Bug Fixes
Chores
Style