Skip to content

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Jan 9, 2025

Close: #264
Close: #387
Close: #407

commit 15a44de

chore: update test matrices

commit 7697ddf

chore: specify a minimum go version for selftest

commit 176c311

chore!: remove helpers package

Conclusion of #458

This also creates KernelSymbolToAddr in selftest common package.

@geyslan geyslan added the chore label Jan 9, 2025
@geyslan geyslan requested a review from yanivagman January 9, 2025 20:12
@geyslan geyslan self-assigned this Jan 9, 2025
@geyslan geyslan force-pushed the helpers-removal branch 2 times, most recently from fed40dd to d3ef66d Compare January 9, 2025 21:26
@geyslan geyslan requested a review from rscampos January 10, 2025 19:48
@geyslan
Copy link
Member Author

geyslan commented Feb 13, 2025

@oshaked1 @OriGlassman please signal us when your end is ready for removal.

@geyslan geyslan force-pushed the helpers-removal branch 2 times, most recently from 7c42467 to 4fc676c Compare April 1, 2025 22:06
@Copilot Copilot AI review requested due to automatic review settings August 12, 2025 22:35
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated helpers package from libbpfgo and migrates dependencies to use the environment package from Tracee. This is a breaking change that eliminates the internal helpers module while updating selftests to use external dependencies.

  • Removes the entire helpers package and all its functionality
  • Migrates selftest dependencies from the helpers package to Tracee's environment package
  • Updates CI configuration to support Go 1.21+ due to Tracee's toolchain requirements

Reviewed Changes

Copilot reviewed 33 out of 40 changed files in this pull request and generated no comments.

Show a summary per file
File Description
helpers/* Complete removal of the deprecated helpers package and all its files
selftest/*/go.mod Updates module dependencies to use Tracee's environment package instead of helpers
selftest/*/main.go Changes import statements from helpers to Tracee's environment package
.github/workflows/pr.yaml Removes helpers unit tests and updates Go version matrix to 1.21+
Makefile Removes helpers test targets and references
docs/helpers.md Removes documentation for the deprecated helpers package
Readme.md Updates documentation to remove helpers-related make targets

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@geyslan geyslan force-pushed the helpers-removal branch 4 times, most recently from abed4fd to e09b6ad Compare August 14, 2025 21:04
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan geyslan force-pushed the helpers-removal branch 2 times, most recently from 1b21042 to a157f37 Compare September 16, 2025 14:40
@geyslan geyslan merged commit 6d09b35 into aquasecurity:main Sep 16, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect parsing of IoUringRequestFlag OSInfo singleton [BUG] KernelSymbolTable exposed to owner value vulnerability
2 participants