-
Notifications
You must be signed in to change notification settings - Fork 100
chore!: remove helpers package #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fed40dd
to
d3ef66d
Compare
5b0845b
to
b55408a
Compare
@oshaked1 @OriGlassman please signal us when your end is ready for removal. |
7c42467
to
4fc676c
Compare
4fc676c
to
32e8139
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated helpers package from libbpfgo and migrates dependencies to use the environment package from Tracee. This is a breaking change that eliminates the internal helpers module while updating selftests to use external dependencies.
- Removes the entire helpers package and all its functionality
- Migrates selftest dependencies from the helpers package to Tracee's environment package
- Updates CI configuration to support Go 1.21+ due to Tracee's toolchain requirements
Reviewed Changes
Copilot reviewed 33 out of 40 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
helpers/* | Complete removal of the deprecated helpers package and all its files |
selftest/*/go.mod | Updates module dependencies to use Tracee's environment package instead of helpers |
selftest/*/main.go | Changes import statements from helpers to Tracee's environment package |
.github/workflows/pr.yaml | Removes helpers unit tests and updates Go version matrix to 1.21+ |
Makefile | Removes helpers test targets and references |
docs/helpers.md | Removes documentation for the deprecated helpers package |
Readme.md | Updates documentation to remove helpers-related make targets |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
abed4fd
to
e09b6ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1b21042
to
a157f37
Compare
Conclusion of aquasecurity#458 This also creates KernelSymbolToAddr in selftest common package.
5b7f1cc
to
15a44de
Compare
Close: #264
Close: #387
Close: #407
commit 15a44de
commit 7697ddf
commit 176c311