Skip to content

chore(deps): updates wazero to 1.0.0-rc.2 #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2023
Merged

chore(deps): updates wazero to 1.0.0-rc.2 #3853

merged 2 commits into from
Mar 19, 2023

Conversation

codefromthecrypt
Copy link
Contributor

Description

This updates wazero to 1.0.0-rc.2 which notably

  • is the final release candidate before 1.0 next Friday.
  • improves instantiation performance (startup time)
  • passes os package tests defined by Go.
  • no longer supports importing unnamed modules.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • [n/a] I've added tests that prove my fix is effective or that my feature works.
  • [n/a] I've updated the documentation with the relevant information (if needed).
  • [n/a] I've added usage information (if the PR introduces new options)
  • [n/a] I've included a "before" and "after" example to the description (if the PR is a user interface change).

@codefromthecrypt
chore(deps): updates wazero to 1.0.0-rc.2
8d69fa2 
This updates [wazero](https://wazero.io/) to [1.0.0-rc.2](https://github.com/tetratelabs/wazero/releases/tag/v1.0.0-rc.2) which notably
* is the final release candidate before 1.0 next Friday.
* improves instantiation performance (startup time)
* passes `os` package tests defined by Go.
* no longer supports importing unnamed modules.

Signed-off-by: Adrian Cole <[email protected]>
@mathetake
Copy link
Contributor

turns out that trivy test has started failing since this commit tetratelabs/wazero@1e7660f

@mathetake
Copy link
Contributor

this seems a bug in aquasecurity/memoryfs on Mode() function's return value, but I haven't gotten around to identify yet.

@mathetake
Copy link
Contributor

basically dir entry of the memfs deosn't set fs.ModeDir in the Mod() bits

@mathetake
Copy link
Contributor

ok here you go aquasecurity/memoryfs#1 @knqyf263

@knqyf263
Copy link
Collaborator

Thank you for figuring out our bug! We're replacing memoryfs with mapfs, then this error will be addressed. I'll update this branch after #3867 gets merged.

@knqyf263 knqyf263 merged commit ad34c98 into aquasecurity:main Mar 19, 2023
@knqyf263
Copy link
Collaborator

Thanks a lot!

@mathetake mathetake deleted the wazero-1.0.0-rc.2 branch March 19, 2023 23:10
@mathetake
Copy link
Contributor

cool passing! thanks you!

@knqyf263 knqyf263 mentioned this pull request Mar 20, 2023
Closed
atombrella pushed a commit to atombrella/trivy that referenced this pull request Mar 25, 2023
@codefromthecrypt @knqyf263 @atombrella
chore(deps): updates wazero to 1.0.0-rc.2 (aquasecurity#3853)
8216e63 
Signed-off-by: Adrian Cole <[email protected]>
Co-authored-by: knqyf263 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codefromthecrypt @mathetake @knqyf263