Skip to content

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented May 7, 2023

Description

Sort our issues/discussions

You can see what it looks like here.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this May 7, 2023
@knqyf263 knqyf263 requested a review from DmitriyLewen May 7, 2023 10:19
@knqyf263 knqyf263 marked this pull request as ready for review May 8, 2023 11:07
@knqyf263 knqyf263 requested a review from chen-keinan May 8, 2023 11:07
attributes:
label: Checklist
options:
- label: Read [the documentation regarding wrong detection](https://aquasecurity.github.io/trivy/latest/community/contribute/discussion/#false-detection)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the page will be generated after this PR gets merged. I forgot to add a note.

@chen-keinan
Copy link
Contributor

lgtm , I have added couple of questions

@knqyf263 knqyf263 force-pushed the discussion_template branch from 7173de8 to 1aac25f Compare May 8, 2023 12:20
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 merged commit 86f0016 into aquasecurity:main May 10, 2023
@knqyf263 knqyf263 deleted the discussion_template branch May 10, 2023 09:06
@itaysk itaysk mentioned this pull request Sep 14, 2023
6 tasks
@itaysk itaysk mentioned this pull request Sep 27, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants