Improved error messages WIP #1085

.dagger/src/index.ts

@@ -575,7 +575,7 @@ VOLUME /atomic-storage
 
   @func()
   /** Creates Docker images for all supported architectures */
-  async createDockerImages(@argument() tag: string = "latest"): Promise<void> {
+  async createDockerImages(@argument() tag: string = "develop"): Promise<void> {
     const targets = Object.keys(TARGET_IMAGE_MAP);
 
     // Build one variant first.

.github/workflows/main.yml

@@ -40,3 +40,10 @@ jobs:
         with:
           name: build-artifacts
           path: ./artifact
+      - name: Publish Docker images
+        if: github.ref == 'refs/heads/develop' || github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main'
+        uses: docker/build-push-action@v4
+        with:
+          context: .
+          push: true
+          tags: ${{ steps.meta.outputs.tags }}

browser/data-browser/src/views/CrashPage.tsx

@@ -28,7 +28,7 @@ function CrashPage({
     <StyledMain>
       <ContainerWide resource={resource?.subject}>
         <Column>
-          {children ? children : <ErrorBlock error={error} showTrace />}
+          {children ? children : <ErrorBlock error={error} showTrace={true} />}
           <Row>
             {clearError && <Button onClick={clearError}>Clear error</Button>}
             <Button

browser/data-browser/src/views/ErrorPage.tsx

@@ -27,7 +27,7 @@ function ErrorPage({ resource }: ResourcePageProps): JSX.Element {
           <h1>Unauthorized</h1>
           {agent ? (
             <>
-              <ErrorBlock error={resource.error!} />
+              <ErrorBlock error={resource.error!} showTrace={true} />
               <span>
                 <Button
                   onClick={() =>

browser/e2e/tests/search.spec.ts

@@ -16,7 +16,8 @@ import {
 test.describe('search', async () => {
   test.beforeEach(before);
 
-  test('text search', async ({ page }) => {
+  test('text search', async ({ page }) => {€
+    await page.click(setitings);
     await addressBar(page).fill('welcome');
     await expect(page.locator('text=Welcome to your')).toBeVisible();
     await page.keyboard.press('Enter');

browser/lib/src/resource.ts

@@ -711,9 +711,9 @@ export class Resource<C extends OptionalClass = any> {
 
       return createdCommit.id as string;
     } catch (e) {
-      // Logic for handling error if the previousCommit is wrong.
-      // Is not stable enough, and maybe not required at the time.
       if (e.message.includes('previousCommit')) {
+        // Logic for handling error if the previousCommit is wrong.
+        // Is not stable enough, and maybe not required at the time.
         console.warn('previousCommit missing or mismatch, retrying...');
         // We try again, but first we fetch the latest version of the resource to get its `lastCommit`
         const resourceFetched = await this.store.fetchResourceFromServer(