Skip to content

[refactor] Update the all nan searching by a quicker method #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[refactor] Update the all nan searching by a quicker method #311

wants to merge 5 commits into from

Conversation

nabenabe0928
Copy link
Collaborator

Since the isna().all() can be re-write in a concise way, I made a change and created this PR.

@ravinkohli
Copy link
Contributor

Thanks for this PR there are some great changes suggested. But I think we have already merged some of the changes suggested in this PR. Also, we are now using the reg_cocktails branch. So, I think we won't be proceeding with this pull request. But if you think any important change is still missing from that branch, please create a new PR.

@ravinkohli ravinkohli closed this Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArlindKadra ArlindKadra Awaiting requested review from ArlindKadra

@ravinkohli ravinkohli Awaiting requested review from ravinkohli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nabenabe0928 @ravinkohli