fix: enable network access for Docker routines to resolve JSR imports #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harbor routines run in containerized Deno environment but couldn't access JSR registry for downloading dependencies like @std/yaml. This caused 'harbor ls' and other commands to fail on Linux systems. The fix adds --network=host to the Docker run command in run_routine(), allowing containers to access external registries while maintaining the same security model (short-lived utility containers with existing filesystem access). Fixes network connectivity issues when downloading JSR packages on Linux systems where Docker's default bridge networking is more restrictive. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--network=hostto Docker run command inrun_routine()functionharbor lsRoot Cause
Harbor runs TypeScript routines in containerized Deno environment. On Linux systems, Docker's default bridge networking prevents containers from accessing external registries like JSR (jsr.io), causing dependency downloads to fail.
This issue didn't occur on Mac due to Docker Desktop's more permissive networking compared to Docker Engine on Linux.
Solution
Added
--network=hostflag to the Docker run command in therun_routine()function (harbor.sh:350). This allows short-lived utility containers to access external registries while maintaining the existing security model.Test Plan
harbor lsworks after clearing Deno cache🤖 Generated with Claude Code