Use Amazon ECR images for mimicing lambda with docker #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddejong
force-pushed
the
fix/ecr/lambdaimage
branch
from
6113ecd to
4a5d9f8
Compare
kddejong
force-pushed
the
fix/ecr/lambdaimage
branch
from
4a5d9f8 to
58b78bb
Compare
kddejong
commented
Sep 23, 2022
| @@ -438,6 +438,7 @@ def test__docker_build_good_path(plugin, tmp_path): | |||
| auto_remove=True, | |||
| volumes={str(tmp_path): {"bind": "/project", "mode": "rw"}}, | |||
| stream=True, | |||
| entrypoint="", | |||
There was a problem hiding this comment.
These images come with an entrypoint. This just removes that entrypoint
ericzbeard
approved these changes
Oct 13, 2022
cmgorton
approved these changes
Oct 13, 2022
kddejong
added a commit
to kddejong/cloudformation-cli-python-plugin
that referenced
this pull request
Oct 13, 2022
kddejong
added a commit
to kddejong/cloudformation-cli-python-plugin
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#192
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.