fix(test) - Pin importlib to make bandit work #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddejong
force-pushed
the
fix/test/bandit/importlib
branch
from
b1e265e to
3e8ccf9
Compare
|
This will fix the current main branch and fix testing of PRs |
mmaeng
approved these changes
Oct 15, 2022
kddejong
changed the title
ericzbeard
approved these changes
Oct 16, 2022
mmaeng
added a commit
that referenced
this pull request
Nov 4, 2022
mmaeng
added a commit
to mmaeng/cloudformation-cli-python-plugin
that referenced
this pull request
Nov 8, 2022
…ws-cloudformation#209) Unpin importlib in bandit pre-commit config This reverts commit 768eed6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
importlib-metadata<5until Tests do not load on Python 3.7 withimportlib-metadata5.0.0 andstevedore3.5.1 PyCQA/bandit#956 is resolvedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.