Skip to content

Conversation

Zegnat
Copy link

@Zegnat Zegnat commented Jul 31, 2025

Thank you for this nice library! I ran into some problems using it in a TypeScript project, this PR seems to fix it, but might need some testing from others. The different fixes are split in different commits.

  1. Upload is not an S3 method b741d4d

    The types were erroring because of UploadCommandOutput, as that does not exist in the SDK. It does not exist in S3 at all. Disabling it from generation for now.

  2. Replace stream with Readable in method signatures 8b1cd90

    There is no primitive type called stream. It looks like the implementation (e.g. put-object.mjs) use an import from node:stream. Make sure the type does the same.

  3. Do not use module augmentation in the module’s declaration 6eb9475

    Fixes errors such as “Exports and export assignments are not permitted in module augmentations.” The main declaration file for the package should not have to declare augmentations of itself. Just define the export at the root level.

    To still support access to the AwsLiteClient interface we can add it to a namespace of what we are exporting.

I could not find a good example of how you update your changelog file, as it seems to be done mostly right before a release is cut?

Zegnat added 4 commits July 31, 2025 10:36
The types were erroring because of UploadCommandOutput, as that does not
exist in the SDK. It does not exist in S3 at all. Disabling it from
generation for now.
There is no primitive type called `stream`. It looks like the
implementation (e.g. put-object.mjs) use an import from node:stream.
Make sure the type does the same.
Fixes errors such as “Exports and export assignments are not permitted
in module augmentations.” The main declaration file for the package
should not have to declare augmentations of itself. Just define the
export at the root level.

To still support access to the AwsLiteClient interface we can add it to
a namespace of what we are exporting.
@richarddd
Copy link

@ryanblock can this be merged please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants