Fix use_ssl parameter ignored when custom HTTPS endpoint_url provided #9704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashovlin
reviewed
Sep 10, 2025
| ) | ||
|
|
||
| with patch.object(resolver._provider, 'resolve_endpoint') as mock_resolve: | ||
| mock_resolve.return_value = RuleSetEndpoint( |
There was a problem hiding this comment.
Looks like we're missing an import that is causing this test to fail in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy from botocore and it was merged: boto/botocore#3542
Fixes a bug where setting
use_ssl=Falsewith a custom HTTPS endpoint incorrectly downgrades the connection to HTTP. According to the documentation, whenendpoint_urlis provided, theuse_sslparameter should be ignored. The fix adds a check to ensure this downgrade only happens when no custom endpoint is specified, preserving the HTTPS protocol when customers explicitly provide an HTTPS URL.