Skip to content

Bug: ValueError when using opensearch.index_df with documents with an array field #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 8, 2022
Merged

Bug: ValueError when using opensearch.index_df with documents with an array field #1444

merged 5 commits into from
Jul 8, 2022

Conversation

malachi-constant
Copy link
Contributor

Bugfix

  • DataFrame values with arrays of a length greater than 1 were causing an exception.

Detail

  • Suggested fix here is to cast all values to numpy array to evaluate all possible cases of v generically.
  • Unknowns here are performance degradation of method & possible types that can't be handled by this approach.

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant added the bug Something isn't working label Jul 7, 2022
@malachi-constant malachi-constant added this to the 2.17.0 milestone Jul 7, 2022
@malachi-constant malachi-constant self-assigned this Jul 7, 2022
@malachi-constant malachi-constant linked an issue Jul 7, 2022 that may be closed by this pull request
ValueError when using opensearch.index_df with documents with an array field #1413
Closed
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 5233959
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 5233959
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 906f413
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking
Copy link
Contributor

kukushking commented Jul 7, 2022 •
edited
Loading

Looks good but could you add a test case covering this just to be sure?

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: a4aee2f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 2340790
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 5ed1b8f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant merged commit 85ac0d7 into main Jul 8, 2022
@jaidisido jaidisido deleted the 1413-valueerror-when-using-opensearchindex_df-with-documents-with-an-array-field branch July 18, 2022 08:12
@kukushking kukushking mentioned this pull request Sep 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukushking kukushking kukushking approved these changes

@jaidisido jaidisido jaidisido approved these changes

Assignees

@malachi-constant malachi-constant

Labels
bug Something isn't working
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.

ValueError when using opensearch.index_df with documents with an array field
3 participants
@malachi-constant @kukushking @jaidisido