Skip to content

upgrading poetry installed in workflow #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2022
Merged

upgrading poetry installed in workflow #1677

merged 2 commits into from
Oct 11, 2022

Conversation

cnfait
Copy link
Contributor

@cnfait cnfait commented Oct 11, 2022

Feature or Bugfix

  • Feature

Detail

  • pin poetry to 1.2.2 (up from 1.1.15)
  • regenerating poetry.lock file using latest poetry
  • poetry 1.2.x used to break in our workflow. I've kept pinning to a specific version instead of just installing the latest as future versions may break things again

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cnfait cnfait added the dependencies Pull requests that update a dependency file label Oct 11, 2022
@cnfait cnfait self-assigned this Oct 11, 2022
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 8081157
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@cnfait cnfait marked this pull request as ready for review October 11, 2022 08:47
@malachi-constant
Copy link
Contributor

They finally fixed it. Nice !

@malachi-constant malachi-constant merged commit fe955b7 into main Oct 11, 2022
@malachi-constant malachi-constant deleted the poetry-update branch October 11, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukushking kukushking kukushking approved these changes

@jaidisido jaidisido jaidisido approved these changes

@malachi-constant malachi-constant Awaiting requested review from malachi-constant

@LeonLuttenberger LeonLuttenberger Awaiting requested review from LeonLuttenberger

Assignees

@cnfait cnfait

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cnfait @malachi-constant @kukushking @jaidisido