Skip to content

feat: add commit_transaction to postgres.to_sql #2795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2024
Merged

feat: add commit_transaction to postgres.to_sql #2795

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b5f37f
feat: add commit_transaction to postgres.to_sql
jaidisido May 1, 2024
cb9841e
Merge branch 'main' into fix/commit-trans-postgres
LeonLuttenberger May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion awswrangler/postgresql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,7 @@ def to_sql(
chunksize: int = 200,
upsert_conflict_columns: list[str] | None = None,
insert_conflict_columns: list[str] | None = None,
commit_transaction: bool = True,
) -> None:
"""Write records stored in a DataFrame into PostgreSQL.

Expand Down Expand Up @@ -542,6 +543,8 @@ def to_sql(
insert_conflict_columns: List[str], optional
This parameter is only supported if `mode` is set top `append`. In this case conflicts for the given columns are
checked for evaluating the insert 'ON CONFLICT DO NOTHING'.
commit_transaction: bool
Whether to commit the transaction. True by default.

Returns
-------
Expand Down Expand Up @@ -606,7 +609,8 @@ def to_sql(
sql: str = f"INSERT INTO {_identifier(schema)}.{_identifier(table)} {insertion_columns} VALUES {placeholders}{upsert_str}"
_logger.debug("sql: %s", sql)
cursor.executemany(sql, (parameters,))
con.commit()
if commit_transaction:
con.commit()
except Exception as ex:
con.rollback()
_logger.error(ex)
Expand Down