Skip to content

fix: handle case of str to bool env variable in config #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 2, 2024
Merged

fix: handle case of str to bool env variable in config #2966

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
47bf607
fix: handle case of str to bool env variable in config
jaidisido Sep 17, 2024
2c757db
fix: add missing empty case
jaidisido Sep 17, 2024
69f05fc
Merge branch 'main' into fix/issue-2965-bool-config
jaidisido Sep 30, 2024
7948327
Merge branch 'main' into fix/issue-2965-bool-config
jaidisido Oct 1, 2024
4af7e52
fix: PR feedback
jaidisido Oct 2, 2024
cc32ceb
not in
jaidisido Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions awswrangler/_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,9 @@ def _apply_type(name: str, value: Any, dtype: type[_ConfigValueType], nullable:
raise exceptions.InvalidArgumentValue(
f"{name} configuration does not accept a null value. Please pass {dtype}."
)
# Handle case where string is empty, "False" or "0". Anything else is True
if isinstance(value, str) and dtype is bool:
return value.lower() not in ("false", "0", "")
try:
return dtype(value) if isinstance(value, dtype) is False else value
except ValueError as ex:
Expand Down
Loading