Skip to content

Support disabling IMDS v1 #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 1, 2023
Merged

Support disabling IMDS v1 #2924

merged 7 commits into from
Nov 1, 2023

Conversation

mullermp
Copy link
Contributor

@mullermp mullermp commented Oct 9, 2023 •
edited
Loading

Allows disabling of IMDS v1 using config.

Also removes refreshing from set? - IMDS is called more than 3 times when checking set credentials.

@mullermp mullermp marked this pull request as ready for review October 9, 2023 22:23
@mullermp
Copy link
Contributor Author

mullermp commented Oct 9, 2023

Pending manual test on EC2

@aws aws deleted a comment from github-actions bot Oct 9, 2023
alextwoods
alextwoods approved these changes Oct 11, 2023
View reviewed changes
@mullermp mullermp merged commit 2cf44d9 into version-3 Nov 1, 2023
@mullermp mullermp deleted the disable-imds-v1 branch November 1, 2023 20:41
@stanhu stanhu mentioned this pull request Nov 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jterapin jterapin Awaiting requested review from jterapin

1 more reviewer

@alextwoods alextwoods alextwoods approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mullermp @alextwoods