Skip to content

Conversation

praneetap
Copy link
Contributor

@praneetap praneetap commented Dec 3, 2019

Issue #, if available:

Description of changes:

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@praneetap praneetap changed the base branch from release/v1.8.0 to release/v1.18.0 December 3, 2019 22:26
@praneetap praneetap merged commit ad9fa12 into aws:release/v1.18.0 Dec 3, 2019
@codecov-io
Copy link

Codecov Report

Merging #1284 into release/v1.18.0 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v1.18.0    #1284      +/-   ##
===================================================
+ Coverage            94.42%   94.43%   +<.01%     
===================================================
  Files                   71       71              
  Lines                 3625     3630       +5     
  Branches               714      717       +3     
===================================================
+ Hits                  3423     3428       +5     
  Misses                 103      103              
  Partials                99       99
Impacted Files Coverage Δ
samtranslator/model/lambda_.py 88.46% <ø> (ø) ⬆️
samtranslator/plugins/globals/globals.py 99.02% <ø> (ø) ⬆️
samtranslator/__init__.py 100% <100%> (ø) ⬆️
samtranslator/model/sam_resources.py 95.56% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69822c1...66f6fdd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants