Skip to content

Conversation

keetonian
Copy link
Contributor

Issue #, if available:
#1300

Description of changes:
Fix securitySchemes to be in the correct place in OpenApi doc.

Description of how you validated changes:
Spec: https://swagger.io/docs/specification/authentication/

Tests updated and verified.

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

@ShreyaGangishetty ShreyaGangishetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@codecov-io
Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #1301 into develop will decrease coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1301      +/-   ##
===========================================
- Coverage    94.61%   94.39%   -0.22%     
===========================================
  Files           78       78              
  Lines         4252     4282      +30     
  Branches       844      854      +10     
===========================================
+ Hits          4023     4042      +19     
- Misses         110      114       +4     
- Partials       119      126       +7
Impacted Files Coverage Δ
samtranslator/open_api/open_api.py 93.6% <100%> (+0.03%) ⬆️
samtranslator/model/eventsources/pull.py 82.05% <0%> (-12.6%) ⬇️
samtranslator/model/eventsources/push.py 90.89% <0%> (+0.01%) ⬆️
samtranslator/model/iam.py 86.36% <0%> (+5.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a66c83...bbcd714. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants