-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Adds support for HostedZoneName instead of HostedZoneId in Domain section of the Api #1408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
examples/2016-10-31/custom_domains_with_route53_hosted_zone_name/template.yaml
Show resolved
Hide resolved
Co-Authored-By: Timo Schilling <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Could you also change/add a unit test here. I think you can just change one of the existing custom domain tests in https://github.com/awslabs/serverless-application-model/tree/develop/tests/translator/input, and you will have to change the corresponding expected outputs in aws, aws-cn and aws-us-gov
…rless-application-model into feature/hosted-zone-name
@praneetap I added the test cases and fixed a bug in the LogicalID generation thatI found because of it, thanks for the guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done and thank you!
@mbarneyjr please run make black, it will auto format for you. That should fix the build. |
…rless-application-model into feature/hosted-zone-name
Looks like it's just a black formatting error. I submitted #1419 to update the black version that our tests use, this PR should be good to go once that is merged. I don't see any other test issues. |
Closed/re-opened PR to kick off a new travis run. The black formatting issues should now be resolved. |
Codecov Report
@@ Coverage Diff @@
## develop #1408 +/- ##
==========================================
Coverage ? 94.42%
==========================================
Files ? 78
Lines ? 4666
Branches ? 932
==========================================
Hits ? 4406
Misses ? 121
Partials ? 139
Continue to review full report at Codecov.
|
@mbarneyjr Thank you for this contribution! |
Issue #, if available:
Issue #1402
Description of changes:
Adds support for inclusion of
HostedZoneName
instead ofHostedZoneId
in theDomain
section of anAWS::Serverless::Api
. This allows users to not need to worry about looking up the hosted zone ID, and letting CloudFormation handle it for them via theAWS::Route53::RecordSetGroup
resource.HostedZoneName
is forwarded to theRecordSetGroup
resource just asHostedZoneId
is.The following should now be valid SAM:
Description of how you validated changes:
Not 100% sure how to validate the changes, didn't immediately see any documentation around it
Checklist:
make pr
passes (It doesn't have any more failures than what is onmaster
)examples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.