Skip to content

Conversation

keetonian
Copy link
Contributor

@keetonian keetonian commented Feb 4, 2020

Issue #, if available:
N/A
Related to PR #1179
Description of changes:
Usage plans, when the SHARED option was selected, was adding the same api multiple times.
Description of how you validated changes:
make pr and updated tests
Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #1434 into release/v1.21.0 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v1.21.0    #1434      +/-   ##
===================================================
+ Coverage            94.37%   94.38%   +<.01%     
===================================================
  Files                   78       78              
  Lines                 4678     4681       +3     
  Branches               934      937       +3     
===================================================
+ Hits                  4415     4418       +3     
  Misses                 121      121              
  Partials               142      142
Impacted Files Coverage Δ
samtranslator/model/api/api_generator.py 95.07% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b47b87...3f86d66. Read the comment docs.

@jlhood jlhood merged commit 4e5625a into aws:release/v1.21.0 Feb 4, 2020
@keetonian keetonian deleted the usage-plan-fix branch March 11, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants