Skip to content

Conversation

keetonian
Copy link
Contributor

@keetonian keetonian commented Mar 11, 2020

Issue #, if available:
#1499
Description of changes:

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@praneetap praneetap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one quick note- can we add documentation? and add it to all the http example templates so people start to follow it as best practice?

@keetonian
Copy link
Contributor Author

Added to documentation. Can add to release notes as well

@codecov-io
Copy link

codecov-io commented Mar 11, 2020

Codecov Report

Merging #1509 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1509      +/-   ##
===========================================
+ Coverage    94.09%   94.09%   +<.01%     
===========================================
  Files           78       78              
  Lines         4925     4928       +3     
  Branches       990      991       +1     
===========================================
+ Hits          4634     4637       +3     
  Misses         135      135              
  Partials       156      156
Impacted Files Coverage Δ
samtranslator/plugins/globals/globals.py 99.05% <ø> (ø) ⬆️
samtranslator/model/sam_resources.py 94.29% <ø> (ø) ⬆️
samtranslator/model/api/http_api_generator.py 91.6% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 354445c...3ebcfe7. Read the comment docs.

@praneetap praneetap merged commit fbc216c into aws:develop Mar 11, 2020
@keetonian keetonian deleted the fail-on-warnings branch March 11, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants