Skip to content

fix(HttpApi): add path parameters if not present #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2020
Merged

fix(HttpApi): add path parameters if not present #1510

merged 2 commits into from
Mar 11, 2020

Conversation

keetonian
Copy link
Contributor

@keetonian keetonian commented Mar 11, 2020 •
edited
Loading

Issue #, if available:
#1499
Description of changes:

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

praneetap
praneetap approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@praneetap praneetap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this so quick :)

@keetonian keetonian changed the title feat(HttpApi): add path parameters if not present fix(HttpApi): add path parameters if not present Mar 11, 2020
@keetonian keetonian mentioned this pull request Mar 11, 2020
Closed
@ShreyaGangishetty ShreyaGangishetty merged commit 287e424 into aws:develop Mar 11, 2020
@keetonian keetonian deleted the path-parameters branch March 11, 2020 18:49
@keetonian keetonian restored the path-parameters branch March 11, 2020 18:54
@ShreyaGangishetty ShreyaGangishetty mentioned this pull request Mar 11, 2020
Closed
@keetonian keetonian deleted the path-parameters branch March 11, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@praneetap praneetap praneetap approved these changes

@ShreyaGangishetty ShreyaGangishetty ShreyaGangishetty approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keetonian @praneetap @ShreyaGangishetty