Added Plex and Docker Socket Proxy service #903
Conversation
There was a problem hiding this comment.
Nice work @marcokreeft87 !
Thanks you for this great addition. A few detail and we should be good to go !
src/components/services/SABnzbd.vue
Outdated
| <p class="title is-4">{{ item.name }}</p> | ||
| <p class="subtitle is-6"> | ||
| <span v-if="error" class="error">An error has occurred.</span> | ||
| <template v-else> |
There was a problem hiding this comment.
Could you also handle the subtitle ? Other services usually works like this : if a subtitle is defined, then display it, otherwise, display the extra information (this way there is still both possibility)
There was a problem hiding this comment.
Isn't that handled by the templating of generic component?
There was a problem hiding this comment.
Once you override the #content template, the content provided by the generic component is not applied anymore.
There was a problem hiding this comment.
My latest commit handles this
I've change everything you've asked, I think haha. Thnx for the suggested improvement :) |
src/components/services/SABnzbd.vue
Outdated
|
|
||
| // For upload speed, you would need a corresponding field in the API response. | ||
| // Assuming there's no direct upload speed in the response, you can modify as needed. | ||
| this.ulSpeed = 0; // Placeholder for upload speed (API might need to provide this) |
There was a problem hiding this comment.
So the upload speed is not available ?
Out of curiosity, is the comments / code from an LLM ? 😃
There was a problem hiding this comment.
Yes the comments are from ChatGPT. But good spot. SabNzbd can't upload :D Didn't really notice that, I've copied the idea from the qBittorrent service, thats why the upload is there
Description
Added 2 services, Plex and docker proxy service.
Added down and upload rate to Sabnzbd service
Fixes # (issue)
Type of change
Checklist:
config.ymlfile