Skip to content

Conversation

tanasegabriel
Copy link
Contributor

@tanasegabriel tanasegabriel commented May 6, 2025

Description

Currently, Pihole always shows a status of enabled, unless one of the HTTP calls involved fails. PiHole can however be temporarily disabled and the old v5 service used to reflect that.

I'm explicitly omitting also updating this, as #927 removes it (to avoid merge conflicts):

if (!this.item.apikey) {
this.handleError(
"API key is required for PiHole authentication",
"disabled",
);

If there's no intention of merging #927, I can amend this!

Fixes # (issue)
Closes #928

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

@tanasegabriel tanasegabriel changed the title Improve PiHole status Improve Pi-hole status May 6, 2025
Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tanasegabriel !

@bastienwirtz bastienwirtz merged commit c230392 into bastienwirtz:main May 20, 2025
5 checks passed
JesusMtnez pushed a commit to JesusMtnez/homelab that referenced this pull request Aug 13, 2025
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker.io/b4bz/homer](https://hub.docker.com/r/b4bz/homer) ([source](https://github.com/bastienwirtz/homer)) | minor | `v25.05.2` -> `v25.08.1` |

---

### Release Notes

<details>
<summary>bastienwirtz/homer (docker.io/b4bz/homer)</summary>

### [`v25.08.1`](https://github.com/bastienwirtz/homer/releases/tag/v25.08.1)

[Compare Source](bastienwirtz/homer@v25.05.2...v25.08.1)

<!-- Release notes generated using configuration in .github/release.yml at v25.08.1 -->

#### What's Changed

##### Main changes

- Improve Pi-hole status by [@&#8203;tanasegabriel](https://github.com/tanasegabriel) in bastienwirtz/homer#929
- Add community theme: DietPi by [@&#8203;Cs137](https://github.com/Cs137) in bastienwirtz/homer#956
- refactor(layouts): remove duplicated code. by [@&#8203;bastienwirtz](https://github.com/bastienwirtz) in bastienwirtz/homer#965
- fix(connectivity-checker): fix network offline issue with auth proxie… by [@&#8203;bastienwirtz](https://github.com/bastienwirtz) in bastienwirtz/homer#966
- chore: Update dependencies by [@&#8203;bastienwirtz](https://github.com/bastienwirtz) in bastienwirtz/homer#967

#### New Contributors

- [@&#8203;Cs137](https://github.com/Cs137) made their first contribution in bastienwirtz/homer#956

**Full Changelog**: bastienwirtz/homer@v25.05.2...v25.08.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS41NS4yIiwidXBkYXRlZEluVmVyIjoiNDEuNTUuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwL21pbm9yIl19-->

Reviewed-on: https://codeberg.org/JesusMtnez/homelab/pulls/788
Co-authored-by: JesusMtnez-bot <[email protected]>
Co-committed-by: JesusMtnez-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pihole v6 always reports a status of enabled unless the HTTP call errors out
2 participants