-
-
Notifications
You must be signed in to change notification settings - Fork 865
Improve Pi-hole status #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bastienwirtz
merged 3 commits into
bastienwirtz:main
from
tanasegabriel:gabriel/improve_pihole_status
May 20, 2025
Merged
Improve Pi-hole status #929
bastienwirtz
merged 3 commits into
bastienwirtz:main
from
tanasegabriel:gabriel/improve_pihole_status
May 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanasegabriel
commented
May 6, 2025
bastienwirtz
requested changes
May 17, 2025
bastienwirtz
approved these changes
May 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tanasegabriel !
JesusMtnez
pushed a commit
to JesusMtnez/homelab
that referenced
this pull request
Aug 13, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.io/b4bz/homer](https://hub.docker.com/r/b4bz/homer) ([source](https://github.com/bastienwirtz/homer)) | minor | `v25.05.2` -> `v25.08.1` | --- ### Release Notes <details> <summary>bastienwirtz/homer (docker.io/b4bz/homer)</summary> ### [`v25.08.1`](https://github.com/bastienwirtz/homer/releases/tag/v25.08.1) [Compare Source](bastienwirtz/homer@v25.05.2...v25.08.1) <!-- Release notes generated using configuration in .github/release.yml at v25.08.1 --> #### What's Changed ##### Main changes - Improve Pi-hole status by [@​tanasegabriel](https://github.com/tanasegabriel) in bastienwirtz/homer#929 - Add community theme: DietPi by [@​Cs137](https://github.com/Cs137) in bastienwirtz/homer#956 - refactor(layouts): remove duplicated code. by [@​bastienwirtz](https://github.com/bastienwirtz) in bastienwirtz/homer#965 - fix(connectivity-checker): fix network offline issue with auth proxie… by [@​bastienwirtz](https://github.com/bastienwirtz) in bastienwirtz/homer#966 - chore: Update dependencies by [@​bastienwirtz](https://github.com/bastienwirtz) in bastienwirtz/homer#967 #### New Contributors - [@​Cs137](https://github.com/Cs137) made their first contribution in bastienwirtz/homer#956 **Full Changelog**: bastienwirtz/homer@v25.05.2...v25.08.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS41NS4yIiwidXBkYXRlZEluVmVyIjoiNDEuNTUuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwL21pbm9yIl19--> Reviewed-on: https://codeberg.org/JesusMtnez/homelab/pulls/788 Co-authored-by: JesusMtnez-bot <[email protected]> Co-committed-by: JesusMtnez-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Pihole always shows a status of
enabled
, unless one of the HTTP calls involved fails. PiHole can however be temporarily disabled and the old v5 service used to reflect that.I'm explicitly omitting also updating this, as #927 removes it (to avoid merge conflicts):
homer/src/components/services/PiHole.vue
Lines 119 to 123 in 30d0265
If there's no intention of merging #927, I can amend this!
Fixes # (issue)
Closes #928
Type of change
Checklist:
config.yml
file